Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for PHPCompatibility 9.0.0 #1498

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Oct 8, 2018

PHPCompatibility 9.0.0 has just been released and renames all sniffs.

  • Updated the version restrictions in composer.json.
    As the sniff names have changed, set minimum version.
    Note: PHPCompatibility 9.0.0 is still compatible with PHPCS 2.3.0 up to current, so this doesn't make a difference for running the CS check.
  • Updated the WPCS native PHPCS ruleset for the new PHPCompatibility sniff codes.
  • Updated the inline annotations for the new PHPCompatibility sniff codes.
  • Updated the phpcs.xml.dist.sample to favour the PHPCompatibilityWP ruleset (was missed in PR Composer & Readme: update organisation name PHPCompatibility #1426).
  • Updated a few more links to the PHPCompatibility repo for the move to an organisation (which were missed in PR Composer & Readme: update organisation name PHPCompatibility #1426).

[PHPCompatibility 9.0.0](https://github.com/PHPCompatibility/PHPCompatibility/releases/tag/9.0.0) has just been released and renames all sniffs.

* Updated the version restrictions in `composer.json`.
    As the sniff names have changed, set minimum version.
    Note: PHPCompatibility 9.0.0 is still compatible with PHPCS 2.3.0 up to current, so this doesn't make a difference for running the sniffs.
* Updated the WPCS native PHPCS ruleset for the new PHPCompatibility sniff codes.
* Updated the inline annotations for the new PHPCompatibility sniff codes.
* Updated the `phpcs.xml.dist.sample` to favour the `PHPCompatibilityWP` ruleset (was missed in PR 1426).
* Updated a few more links to the PHPCompatibility repo for the move to an organisation (which were missed in PR 1426).
@jrfnl jrfnl merged commit 3d685d5 into develop Oct 31, 2018
@jrfnl jrfnl deleted the feature/update-phpcompatibility-9.0.0 branch October 31, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants